[PATCH] [RESEND] pcmcia: badge4: avoid unused function warning

Arnd Bergmann arnd at arndb.de
Mon Sep 11 13:11:15 PDT 2017

The pcmv_setup is only used when the badge4 driver is built-in, but
not when it is a loadable module:

drivers/pcmcia/sa1111_badge4.c:153:122: error: 'pcmv_setup' defined but not used [-Werror=unused-function]

This adds an #ifdef to avoid the definition of the unused function
in the modular case.

Signed-off-by: Arnd Bergmann <arnd at arndb.de>
Patch was sent on Jan 25 2016, and on July 21, 2017 but got no

Andrew, could you pick it up?
 drivers/pcmcia/sa1111_badge4.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pcmcia/sa1111_badge4.c b/drivers/pcmcia/sa1111_badge4.c
index 2f490930430d..93a5c7423d80 100644
--- a/drivers/pcmcia/sa1111_badge4.c
+++ b/drivers/pcmcia/sa1111_badge4.c
@@ -144,6 +144,7 @@ int pcmcia_badge4_init(struct sa1111_dev *dev)
+#ifndef MODULE
 static int __init pcmv_setup(char *s)
 	int v[4];
@@ -158,3 +159,4 @@ static int __init pcmv_setup(char *s)
 __setup("pcmv=", pcmv_setup);

More information about the linux-pcmcia mailing list