[PATCH 2/5] Dynamic ID addition doesn't need get_driver()

Jesse Barnes jbarnes at virtuousgeek.org
Fri Jan 27 13:40:05 EST 2012

On Tue, 24 Jan 2012 13:34:41 -0500 (EST)
Alan Stern <stern at rowland.harvard.edu> wrote:

> As part of the removal of get_driver()/put_driver(), this patch
> (as1511) changes all the places that add dynamic IDs for drivers.
> Since these additions are done by writing to the drivers' sysfs
> attribute files, and the attributes are removed when the drivers are
> unregistered, there is no reason to take an extra reference to the
> drivers.
> The one exception is the pci-stub driver, which calls pci_add_dynid()
> as part of its registration.  But again, there's no reason to take an
> extra reference here, because the driver can't be unloaded while it is
> being registered.

Looks fine, you can add my ack too.

Jesse Barnes, Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-pcmcia/attachments/20120127/b3ed233f/attachment.sig>

More information about the linux-pcmcia mailing list