ds.h: unnecessary bit-field

Komuro komurojun-mbn at nifty.com
Sat Jul 24 06:13:48 EDT 2010


Hi,

bit-field sometimes introduces locking problem.
for example, if one cpu loads the value "suspended",
it also loads other value ("_irq", "_io" ..) at the same time.
 
so it should not be used?

[include/pcmcia/ds.h]

        u16                     suspended:1;

        /* Flags whether io, irq, win configurations were
         * requested, and whether the configuration is "locked" */
        u16                     _irq:1;
        u16                     _io:1;
        u16                     _win:4;
        u16                     _locked:1;

        /* Flag whether a "fuzzy" func_id based match is
         * allowed. */
        u16                     allow_func_id_match:1;

        /* information about this device */
        u16                     has_manf_id:1;
        u16                     has_card_id:1;
        u16                     has_func_id:1;

        u16                     reserved:4;




More information about the linux-pcmcia mailing list