[PATCH V2] pcmcia/yenta: add module parameter for O2 speedups

Wolfram Sang w.sang at pengutronix.de
Mon Jan 11 11:33:58 EST 2010


Hi,

> (1)
> The default setting of O2_6933 should be "on"?

It was set to "off" because of this bug-report:

http://www.mail-archive.com/linux-pcmcia@lists.infradead.org/msg02048.html

The patch went through this list multiple times and there were no complaints.

> (2)
> How about the name "enable_prefetch" instead of "o2_speedup"?

Hmm, prefetch is only for read, for write it is called "burst", so I took this
name. Also, I'd think it should have "o2" somewhere in the name, as it doesn't
do anything on other controllers. I also didn't find existing parameters doing
something similar, otherwise I would have tried to group them.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-pcmcia/attachments/20100111/d406c87d/attachment.sig>


More information about the linux-pcmcia mailing list