[patch 1/1] drivers/pcmcia/yenta_socket.c: ENE CB712 CardBus bridge needs special treatment with Echo Audio Indigo soundcards

[Dominik Brodowski]

Hey,

On Wed, Feb 03, 2010 at 11:04:44AM +0100, Wolfram Sang wrote:
> Andrew,
> 
> On Tue, Feb 02, 2010 at 02:39:47PM -0800, akpm at linux-foundation.org wrote:
> > From: Michal Pecio <michal.pecio at gmail.com>
> > 
> > Indigos are well known for distortions when running on some buggy ENE
> > controllers.  There is a workaround in the yenta driver, but for some
> > reason it isn't activated on CB712.  However, I own a laptop with such
> > chip and it seems that it also is affected - I can clearly hear occasional
> > cracks, especially under heavy network load, and in Windows XP the card is
> > completely unusable.
> > 
> > This simple change fixed things for me.
> > 
> > Addresses http://bugzilla.kernel.org/show_bug.cgi?id=15191
> 
> I guess you did not want to change ENE710/720 (mentioned in the PDF-file of the
> bug report) until there is someone who can verify the change? Maybe a comment
> in yenta_table could be useful that the change to ENE might be needed?
> 
> > 
> > Cc: Dominik Brodowski <linux at dominikbrodowski.net>
> > Cc: Daniel Ritz <daniel.ritz at gmx.ch>
> > Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
> > ---
> > 
> >  drivers/pcmcia/yenta_socket.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff -puN drivers/pcmcia/yenta_socket.c~drivers-pcmcia-yenta_socketc-ene-cb712-cardbus-bridge-needs-special-treatment-with-echo-audio-indigo-soundcards drivers/pcmcia/yenta_socket.c
> > --- a/drivers/pcmcia/yenta_socket.c~drivers-pcmcia-yenta_socketc-ene-cb712-cardbus-bridge-needs-special-treatment-with-echo-audio-indigo-soundcards
> > +++ a/drivers/pcmcia/yenta_socket.c
> > @@ -1408,7 +1408,7 @@ static struct pci_device_id yenta_table[
> >  	CB_ID(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_7610, TI12XX),
> >  
> >  	CB_ID(PCI_VENDOR_ID_ENE, PCI_DEVICE_ID_ENE_710, TI12XX),
> > -	CB_ID(PCI_VENDOR_ID_ENE, PCI_DEVICE_ID_ENE_712, TI12XX),

Any idea why the ENE 712 is removed here?

> > +	CB_ID(PCI_VENDOR_ID_ENE, PCI_DEVICE_ID_ENE_712, ENE),
> >  	CB_ID(PCI_VENDOR_ID_ENE, PCI_DEVICE_ID_ENE_720, TI12XX),
> >  	CB_ID(PCI_VENDOR_ID_ENE, PCI_DEVICE_ID_ENE_722, TI12XX),
> >  	CB_ID(PCI_VENDOR_ID_ENE, PCI_DEVICE_ID_ENE_1211, ENE),
> > _
> > 
> > _______________________________________________
> > Linux PCMCIA reimplementation list
> > http://lists.infradead.org/mailman/listinfo/linux-pcmcia

Best,
	Dominik