[PATCH 2/2] drivers/mtd/maps/pcmciamtd.c: coding style cleanups

Wolfram Sang w.sang at pengutronix.de
Mon Apr 12 21:06:17 EDT 2010


On Mon, Apr 12, 2010 at 07:51:12PM +0400, Alexander Kurz wrote:
> From df0e6529165643058e87595f40258a08bc01fec5 Mon Sep 17 00:00:00 2001
> From: Alexander Kurz <linux at kbdbabel.org>
> Date: Sun, 11 Apr 2010 23:07:19 +0200
> Subject: [PATCH 2/2] drivers/mtd/maps/pcmciamtd.c: coding style cleanups
> 
> Signed-off-by: Alexander Kurz <linux at kbdbabel.org>
> ---
>  drivers/mtd/maps/pcmciamtd.c |   55 +++++++++++++++++++++++++----------------
>  1 files changed, 33 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/mtd/maps/pcmciamtd.c b/drivers/mtd/maps/pcmciamtd.c
> index 2dbe939..0db1ac4 100644
> --- a/drivers/mtd/maps/pcmciamtd.c
> +++ b/drivers/mtd/maps/pcmciamtd.c
> @@ -40,10 +40,7 @@ MODULE_PARM_DESC(debug, "Set Debug Level 0=quiet, 5=noisy");
>  static const int debug = 0;
>  #endif
>  
> -#define err(format, arg...) printk(KERN_ERR "pcmciamtd: " format "\n" , ## arg)
>  #define info(format, arg...) printk(KERN_INFO "pcmciamtd: " format "\n" , ## arg)
> -#define warn(format, arg...) printk(KERN_WARNING "pcmciamtd: " format "\n" , ## arg)
> -
>  
>  #define DRIVER_DESC	"PCMCIA Flash memory card driver"
>  
> @@ -100,7 +97,9 @@ module_param(mem_type, int, 0);
>  MODULE_PARM_DESC(mem_type, "Set Memory type (0=Flash, 1=RAM, 2=ROM, default=0)");
>  
>  
> -/* read/write{8,16} copy_{from,to} routines with window remapping to access whole card */
> +/* read/write{8,16} copy_{from,to} routines with window remapping
> + * to access whole card
> + */

When you are touching these anyway: CodingStyle suggests

	/*
	 * Multi
	 * line comment
	 */

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-pcmcia/attachments/20100413/c3367f79/attachment.sig>


More information about the linux-pcmcia mailing list