[patch 14/38] pcmcia: id_table for wavelan_cs

[Jean Tourrilhes]

On Sun, Feb 27, 2005 at 05:13:08PM +0100, Dominik Brodowski wrote:
> Add pcmcia_device_id table.
> 
> Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.net>

	Hi,

	Sorry for the late reply...

> +static struct pcmcia_device_id wavelan_ids[] = {
> +	PCMCIA_DEVICE_PROD_ID1("AT", 0x8564eba9),

	This one seems bogus and won't match anything useful.

	On the other hand, this one seems missing :
+	PCMCIA_DEVICE_PROD_ID12("AT&T", "WaveLAN/PCMCIA", 0x??????, 0x??????),

	Also, what's up with the magic numbers ? Couldn't they be
autogenerated by the macro ? I guess they are a hash based on the
strings. Like this, it seems quite prone to mistyping and other stupid
cut'n'paste problems, and not very author friendly...


> +	PCMCIA_DEVICE_PROD_ID12("Digital", "RoamAbout/DS", 0x9999ab35, 0x00d05e06),
> +	PCMCIA_DEVICE_PROD_ID12("Lucent Technologies", "WaveLAN/PCMCIA", 0x23eb9949, 0x1bc50975),
> +	PCMCIA_DEVICE_PROD_ID12("NCR", "WaveLAN/PCMCIA", 0x24358cd4, 0x1bc50975),

	All good (I did not check the magic numbers).

	Jean