PCMCIA fun

[Russell King]

On Thu, Mar 18, 2004 at 10:14:44AM +0100, Geert Uytterhoeven wrote:
> On Wed, 17 Mar 2004, Kars de Jong wrote:
> > - drivers/pcmcia/rsrc_mgr.c:
> >   Uses readl() on ioremapped() PCMCIA common memory, but we don't define
> >   readl() unless CONFIG_PCI is defined. I added isa_readl() and
> >   isa_writel() and defined readl() and writel() to use those when
> >   CONFIG_ISA is enabled. Gayle can handle these just fine, I don't know
> >   how to define isa_mtl() for CONFIG_Q40 and CONFIG_GG2 though. Richard?
> 
> That's a bug in rsrc_mgr.c: since PCMCIA is ISA, it should use isa_readl()
> instead of readl().

No - consider the case where PCMCIA is on the end of a PCI bus, which
may be a different PCI bus from the one with your ISA bus on.

It isn't that clear cut.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core