[Linux-parport] [PATCH 1/6] sparc32: Use generic cmpdi2/ucmpdi2 variants

Maciej W. Rozycki macro at orcam.me.uk
Fri Feb 23 18:54:28 PST 2024


On Fri, 23 Feb 2024, Sam Ravnborg via B4 Relay wrote:

> Use the generic variants - the implementation is the same.
> As a nice side-effect fix the following warnings:
> 
> cmpdi2.c: warning: no previous prototype for '__cmpdi2' [-Wmissing-prototypes]
> ucmpdi2.c: warning: no previous prototype for '__ucmpdi2' [-Wmissing-prototypes]
> 
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: "David S. Miller" <davem at davemloft.net>
> Cc: Andreas Larsson <andreas at gaisler.com>
> ---

 LGTM.  You may wish to add:

Fixes: 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally")

but otherwise:

Reviewed-by: Maciej W. Rozycki <macro at orcam.me.uk>
Tested-by: Maciej W. Rozycki <macro at orcam.me.uk> # build-tested

  Maciej



More information about the Linux-parport mailing list