[Linux-parport] [PATCH 00/32] pata_parport-bpck6: rework bpck6 protocol driver
Sergey Shtylyov
s.shtylyov at omp.ru
Sun Mar 19 13:02:43 PDT 2023
On 3/18/23 9:55 PM, Ondrej Zary wrote:
>>> This patch series simplifies bpck6 code, removing ppc6lnx.c file to match
>>> the simplicity of other protocol drivers. It also converts the direct
>>> port I/O access to paraport access functions. This conversion revealed that
>>> there's no 8-bit and 16-bit EPP support in parport_pc so patch 11 implements
>>> that.
>>>
>>> Tested with Backpack CD-RW 222011 and CD-RW 19350.
>>>
>>> Signed-off-by: Ondrej Zary <linux at zary.sk>
>>> ---
>>> drivers/ata/pata_parport/bpck6.c | 452 +++++++++++++++++++++++++++--------
>>> drivers/ata/pata_parport/ppc6lnx.c | 726 ---------------------------------------------------------
>>> drivers/parport/parport_pc.c | 20 +-
>>> include/uapi/linux/parport.h | 3 +
>>> 4 files changed, 370 insertions(+), 831 deletions(-)
>>
>> OK, it's finally clear I can't keep up with reviewing 32 patches posted
>> at once... Luckily, all those patches seem to be dealing with parallel port
>> control), not the PATA control! Of course, when I volunteered to review the
>> PATA driver patches, I didn't expect such patch volumes -- I mostly expected
>> some odd fixes, not a massive driver rework... :-/
>
> So you're going to review the (P)ATA parts (if any) only.
I saw no PATA parts in this patcheset...
> Maybe Sudip (as parport maintainer) could review the parallel port parts?
I have no objections! :-)
MBR, Sergey
More information about the Linux-parport
mailing list