[Linux-parport] [PATCH 0/2] USB: usbserial: mos7720: support for parallel port on moschip 7715
Mike Dunn
mikedunn at newsguy.com
Thu Apr 15 17:01:00 EDT 2010
Hi all,
This patchset adds support for the parallel port on the moschip MCS7715
device to the mos7720 driver. The port registers itself with the parport
subsystem as a low-level driver.
In the kernel configuration, I added a separate option for parallel port support
beneath that for the mos7720 serial port(s) so that 7720 users (or 7715
users not interested in the parallel port) do not have to unnecessarily link to
the parport subsystem code.
The first patch adds the support. The second adds no functionality or
fixes no bugs, but eliminates some code redundancy and improves readability
(IMO) by eliminating send_mos_cmd() in favor of the register read/write fns I
wrote for the parallel port (I originally did the parallel port work as a
separate module). It can be rejected with no loss of functionality if deemed
too risky.
I did spend a lot of time testing both patches with both 7715 and 7720 devices,
on both UP and SMP hosts, x86 and x86_64, trying to cover all execution paths
and ensure good behavior on disconnect (especially during port operation). Also
have been using it regularly for a couple months to drive a printer.
This was originally sent a couple months ago, but these patches are on top of
latest from the linux-next tree.
Comments / criticisms of course gratefully received.
Thanks,
Mike
More information about the Linux-parport
mailing list