[PATCH] nvme-tcp: wait for in-flight TLS handshake callback

[Avi Weiss]

It seems relatively independent (and pre-existing) no?
I could address it but I think it's also fine as a separate (future) patch.
Just let me know.
Cheers,
Avi

On Wed, 28 Oct 2026 at 16:57, Christoph Hellwig <hch at lst.de> wrote:
>
> On Thu, Oct 22, 2026 at 10:19:34AM +0300, Avi Weiss wrote:
> > When nvme_tcp_start_tls() times out or is interrupted,
> > tls_handshake_cancel() can return false after handshake_complete()
> > marks the request completed, but before nvme_tcp_tls_done()
> > finishes. Error cleanup can then release the queue while the
> > callback still accesses it.
> >
> > Wait for queue->tls_complete when cancellation loses, before
> > continuing cleanup. Preserve the original timeout or signal error.
>
> Plase take a look at the Sashiko complaint:
>
> https://sashiko.dev/#/patchset/20261022071934.3818224-1-thnkslprpt%40gmail.com
>
> it looks valid from a quick glance.
>