[PATCH] nvme-auth: update error log in nvme_auth_submit()
Hannes Reinecke
hare at suse.de
Wed Oct 21 03:47:09 PDT 2026
On 10/21/26 10:36 AM, Martin George wrote:
> nvme_auth_submit() issues both AUTH Send and AUTH Receive commands,
> but the failure messages are hardcoded to "auth_send failed", which
> can be misleading when an AUTH Receive fails. So print the correct
> direction instead.
>
> Signed-off-by: Martin George <marting at netapp.com>
> ---
> drivers/nvme/host/auth.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
> index cbb38935fa22..85f005a5efd0 100644
> --- a/drivers/nvme/host/auth.c
> +++ b/drivers/nvme/host/auth.c
> @@ -85,10 +85,12 @@ static int nvme_auth_submit(struct nvme_ctrl *ctrl, int qid,
> qid == 0 ? NVME_QID_ANY : qid, flags);
> if (ret > 0)
> dev_warn(ctrl->device,
> - "qid %d auth_send failed with status %d\n", qid, ret);
> + "qid %d auth_%s failed with status %d\n",
> + qid, auth_send ? "send" : "receive", ret);
> else if (ret < 0)
> dev_err(ctrl->device,
> - "qid %d auth_send failed with error %d\n", qid, ret);
> + "qid %d auth_%s failed with error %d\n",
> + qid, auth_send ? "send" : "receive", ret);
> return ret;
> }
>
Reviewed-by: Hannes Reinecke <hare at kernel.org>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare at suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
More information about the Linux-nvme
mailing list