[PATCH] nvme-core: fix unsigned comparison warning in nvme_wait_freeze_timeout
Maurizio Lombardi
mlombard at redhat.com
Thu May 21 05:29:40 PDT 2026
The timeout variable in nvme_wait_freeze_timeout() is an unsigned type.
Checking if it is <= 0 triggers a compiler warning because an unsigned
variable can never be negative.
Fix this warning by changing the condition to !timeout.
blk_mq_freeze_queue_wait_timeout() is a wrapper for
wait_event_timeout() and the latter returns 0 or a positive value.
Reported-by: kernel test robot <lkp at intel.com>
Reported-by: Dan Carpenter <error27 at gmail.com>
Closes: https://lore.kernel.org/r/202605211257.STzj2Ujv-lkp@intel.com/
Fixes: 23b6d2cbf75f ("nvme: remove redundant timeout argument from nvme_wait_freeze_timeout")
Signed-off-by: Maurizio Lombardi <mlombard at redhat.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 72c50d5e938d..26a65404279f 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -5254,7 +5254,7 @@ int nvme_wait_freeze_timeout(struct nvme_ctrl *ctrl)
list_for_each_entry_srcu(ns, &ctrl->namespaces, list,
srcu_read_lock_held(&ctrl->srcu)) {
timeout = blk_mq_freeze_queue_wait_timeout(ns->queue, timeout);
- if (timeout <= 0)
+ if (!timeout)
break;
}
srcu_read_unlock(&ctrl->srcu, srcu_idx);
--
2.54.0
More information about the Linux-nvme
mailing list