[PATCH] nvme: use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE for multipath_sysfs

John Garry john.g.garry at oracle.com
Fri May 15 01:34:30 PDT 2026


On 15/05/2026 05:45, Christoph Hellwig wrote:
> On Wed, May 13, 2026 at 09:50:30AM +0000, John Garry wrote:
>> Use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE instead of
>> DEFINE_SYSFS_GROUP_VISIBLE, which means that we can drop
>> multipath_sysfs_attr_visible().
>>
>> Incidentally, multipath_sysfs_attr_visible() should have returned a
>> umode_t.
> 
> Looks ok, although all the magic symbol name concatenation in the
> sysfs code drives me a bit crazy.

yeah, lots of #/## from those sysfs helpers

> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Reviewed-by?

cheers



More information about the Linux-nvme mailing list