[PATCH 6/9] libnvme: add support for per-path diagnostic counters
Daniel Wagner
dwagner at suse.de
Tue Mar 24 02:18:04 PDT 2026
On Sat, Mar 21, 2026 at 08:58:05PM +0530, Nilay Shroff wrote:
> Add support for retrieving per-path diagnostic counters such as
> command_retry_count, command_error_count, and multipath_failover_count.
> These counters improve visibility into NVMe native multipath behavior
> and can be useful for tools such as nvme-top to display real-time
> statistics.
>
> Unlike other sysfs attributes, these counters can change dynamically.
> Annotate them with "!accessors:none" and provide custom implementations
> to always retrieve the latest (non-cached) values.
If I got this right, this and the next patches depend on
https://lore.kernel.org/all/20260220175024.292898-1-nilay@linux.ibm.com
Should we wait with interfaces here until they are ready? As we
currently still in the development phase of nvme-cli 3 and thus the API
is not stable, we can touch it again. In the past we also added support
for kernel feature which weren't there yet. I don't mind too much, just
asking what would be best here.
The whole series looks pretty good, just my nitpicks and the question
on exposing 'cur'/'this'.
More information about the Linux-nvme
mailing list