[PATCHv3 0/7] nvme: export additional diagnostic counters via sysfs

[Keith Busch]

On Wed, Mar 04, 2026 at 08:03:02PM +0530, Nilay Shroff wrote:
> Hi Keith,
> 
> A gentle ping on this. I´ve incorporated the review comments,
> and the series has already received Reviewed-by and Tested-by tags.
> 
> Could you please consider pulling it? Also, please let me know if
> you have any further comments or if additional changes are needed.

Thanks, I was hoping free time would show up to let me look closer at
this, but that doesn't appear to be happening, so looks like I have to
force the time :)

We always need to be a bit cautious on adding user visible attributes,
so just throwing out some thoughts on this feature.

The event counters are not atomic. I know these are informational, so
maybe it's not important to be 100% accurate in the reporting, but I
don't know. Maybe you do want accuracy in which case using atomic_long_t
might be the right type. I think that should be okay to use since none
of these counters are in the normal fast path.

The names of the attributes are a bit inconsistent. Some have a "_count"
suffix, some have "_events" suffix, and some have no suffix at all.

In order to keep sysfs a bit cleaner, should we consider moving these
attributes under a sub-directory specifically for reporting event
counters?

Last thought, as you are probably aware, John Garry is proposing to
lift the nvme multipath into a generic library, which suggests many of
these events would also need to be generic. Should some of these, like
error and retry counts, be appended to the generic disk stats instead?