[PATCH 03/13] libmultipath: Add path selection support

John Garry john.g.garry at oracle.com
Wed Mar 4 06:38:54 PST 2026


On 04/03/2026 13:10, Nilay Shroff wrote:
> On 2/25/26 9:02 PM, John Garry wrote:
>> +static struct mpath_device *__mpath_find_path(struct mpath_head 
>> *mpath_head,
>> +            enum mpath_iopolicy_e iopolicy, int node)
>> +{
>> +    int found_distance = INT_MAX, fallback_distance = INT_MAX, distance;
>> +    struct mpath_device *mpath_dev_found, *mpath_dev_fallback,
>> +            *mpath_device;
>> +
> 
> I think we should initialize mpath_dev_found and mpath_dev_fallback to
> NULL. Otherwise this may lead upto adding a junk mpath_device pointer
> in ->current_path[node] when mpath_head->dev_list is empty. This may
> particularly manifests when a controller is being shutdown and
> concurrently I/O is forwarded to the same controller.

Right, I see that we were doing the equivalent in __nvme_find_path(). 
Will fix.

Thanks for the notice.




More information about the Linux-nvme mailing list