[PATCH 04/24] scsi-multipath: introduce scsi_mpath_device_class

John Garry john.g.garry at oracle.com
Mon Mar 2 04:01:34 PST 2026


On 02/03/2026 02:54, Benjamin Marzinski wrote:
>> static bool scsi_multipath_sysfs_attr_visible(struct kobject *kobj,
>> +		struct attribute *attr, int n)
> The return for this is actually a umode_t.
> 
>> +{
>> +	return false;
>> +}
>> +DEFINE_SYSFS_GROUP_VISIBLE(scsi_multipath_sysfs)
> Nitpick again: This could just use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE()
> Also, this code would make more sense in the next patch.

ok, can change, thanks!



More information about the Linux-nvme mailing list