[PATCH blktests 0/3] fix module unload failures
Shinichiro Kawasaki
shinichiro.kawasaki at wdc.com
Sun Mar 1 16:30:41 PST 2026
On Feb 24, 2026 / 17:40, Daniel Wagner wrote:
> On Mon, Feb 23, 2026 at 12:50:20PM +0900, Shin'ichiro Kawasaki wrote:
[...]
> > From these observations, I identified two problems below.
> >
> > 1) The requirement check for the loop transport left the nvmet and nvme-
> > loop modules loaded and it affected the following test. In the
> > current implementation, the helper function _unload_modules() is
> > called once, only after nvme/060 has been executed for all specified
> > transport types. Instead, _unload_modules() should be called after
> > each run of test test case for every transport. This ensures that the
> > modules loaded for the requirement check are unloaded.
> >
> > 2) When _setup_nvmet() does not load the nvmet module, there is no need
> > for _cleanup_nvmet() to attempts to unload it. _cleanup_nvmet()
> > should unload a module only if it was loaded by _setup_nvmet().
> >
> > This series addresses these two problems. The first patch fixes the
> > first problem. The other two patches fix the second problem.
>
> Looks good to me.
>
> Reviewed-by: Daniel Wagner <dwagner at suse.de>
Thanks for the review. FYI, I applied the patches.
More information about the Linux-nvme
mailing list