[PATCHv2 2/3] nvme-multipath: rescan siblings on last path removal
Nilay Shroff
nilay at linux.ibm.com
Fri Feb 27 07:57:26 PST 2026
On 2/27/26 9:04 PM, Keith Busch wrote:
> On Fri, Feb 27, 2026 at 12:29:00PM +0530, Nilay Shroff wrote:
>> Should we consider reordering patches 2/3 and 3/3? It seems like this
>> patch depends on the changes introduced in 3/3.
>>
>> Without the updates from 3/3, if delayed head removal is still in effect
>> and the NSIDs are recycled with mismatched identifiers, a forced rescan
>> of the sibling controller may still fail to instantiate the namespace.
>> In that case, requeueing the scan alone might not be sufficient.
>
> But the other way around, if we're racing with another controller's scan
> to complete the last path removal, then the delayed work hasn't been
> scheduled yet so patch 3 has a significant gap without patch 2 preceding
> it.
Yes, that’s also correct — both patches depend on each other to some extent.
If the user does not configure delayed_removal_sec, then patch 2 by itself
is sufficient to resolve the race. So with that, overall, the changes look
good to me:
Reviewed-by: Nilay Shroff <nilay at linux.ibm.com>
More information about the Linux-nvme
mailing list