[PATCH RFC 2/5] nvme: add sysfs attribute to change admin timeout per nvme controller

Maurizio Lombardi mlombard at arkamax.eu
Wed Feb 18 06:49:23 PST 2026


On Wed Feb 18, 2026 at 1:40 PM CET, Maximilian Heyne wrote:
>> +
>> +static struct device_attribute dev_attr_admin_timeout =  \
>> +	__ATTR(admin_timeout, S_IRUGO | S_IWUSR, \
>> +	nvme_admin_timeout_show, nvme_admin_timeout_store);
>
> Why not
>
>   DEVICE_ATTR(admin_timeout, S_IRUGO | S_IWUSR, nvme_admin_timeout_show
>   nvme_admin_timeout_store);
>
> ?

No valid reason, I must have copy-pasted it from the old patchset sent
by David Jeffery.

I will fix it, thanks.

Maurizio




More information about the Linux-nvme mailing list