[PATCH 3/3] nvme-pci: do not try to add queue maps at runtime

Christoph Hellwig hch at lst.de
Wed Feb 11 07:58:11 PST 2026


On Tue, Feb 10, 2026 at 11:37:15AM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch at kernel.org>
> 
> The block layer allocates the set's maps once. We can't add special
> purpose queues at runtime if they weren't allocated at initialization
> time.

Same here, a comment in the code would be helpful.

> +	if (dev->ctrl.tagset) {
> +		switch (dev->ctrl.tagset->nr_maps) {
> +		case 1:
> +			dev->nr_write_queues = 0;
> +			dev->nr_poll_queues = 0;
> +			break;
> +		case 2:
> +			dev->nr_poll_queues = 0;
> +			break;

Maybe use fallthrough or just two ifs to condense this a tiny bit?

Otherwise looks good.




More information about the Linux-nvme mailing list