[PATCH 3/4] nvmet: prevent max_qid changes for discovered subsystems

Daniel Wagner dwagner at suse.de
Thu Sep 25 23:58:58 PDT 2025


On Fri, Sep 26, 2025 at 01:09:22AM +0300, Max Gurtovoy wrote:
> I'm not an expert in the blktests but it seems like we should do inside the
> set_qid_max() something like:
> 
> _nvmet_target_cleanup
> _nvmet_target_setup --blkdev file (Add here --qid_max "${qid_max}" option)
> nvmf_check_queue_count "${subsysnqn}" "${qid_max}" || return 1
> _nvmf_wait_for_state "${subsysnqn}" "live" || return 1
> 
> I expect the above to work with and without my patches..

My patch was just a quick hack to see if it works. Updating
__nvmet_target_setup to handle the qid_max argument is the right
approach. 
 
> If possible - lets try it also with tcp/rdma transports

You are proposing a patch which has never run blktests, as it clearly
would regress nvme/048. I don't see myself here to do your work.



More information about the Linux-nvme mailing list