[PATCH 3/3] nvmet: replace transports array with a linked list
Max Gurtovoy
mgurtovoy at nvidia.com
Mon Sep 22 14:45:20 PDT 2025
On 23/09/2025 0:27, Keith Busch wrote:
> On Tue, Sep 23, 2025 at 12:19:59AM +0300, Max Gurtovoy wrote:
>> maybe we can do something like this instead:
>>
>> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
>> index 655d194f8e72..8e076960875c 100644
>> --- a/include/linux/nvme.h
>> +++ b/include/linux/nvme.h
>> @@ -68,7 +68,7 @@ enum {
>> NVMF_TRTYPE_RDMA = 1, /* RDMA */
>> NVMF_TRTYPE_FC = 2, /* Fibre Channel */
>> NVMF_TRTYPE_TCP = 3, /* TCP/IP */
>> - NVMF_TRTYPE_LOOP = 254, /* Reserved for host usage */
>> + NVMF_TRTYPE_LOOP = 15, /* Reserved for host usage */
>> NVMF_TRTYPE_MAX,
>> };
> The 254 value for the host loopback transport type is in defined that
> way in the fabrics spec, so we can't readily change in the driver.
ohh, I was sure it's out of spec but I guess you're right.
Anyway, we use a list in the host fabrics driver for the same purpose so
we probably need to align having a single design: an array with const
structures or a list with non-const structures
More information about the Linux-nvme
mailing list