[PATCH v3 3/4] nvme-fc: refactore nvme_fc_reconnect_or_delete

Hannes Reinecke hare at suse.de
Mon Sep 1 23:47:11 PDT 2025


I guess the subject should be 'refactor nvme_fc_reconnect_or_delete'

On 8/29/25 17:37, Daniel Wagner wrote:
> Instead using if else blocks, apply the 'early return' and 'goto out'
> pattern. This reduces the overall complexity of this function as the
> conditions can be read in a linear order.
> 
> The only function change is that always the next reconnect attempt
> message will be printed.
> 
> Signed-off-by: Daniel Wagner <wagi at kernel.org>
> ---
>   drivers/nvme/host/fc.c | 64 +++++++++++++++++++++++++++-----------------------
>   1 file changed, 34 insertions(+), 30 deletions(-)
> 
Otherwise:

Reviewed-by: Hannes Reinecke <hare at suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich



More information about the Linux-nvme mailing list