[PATCH 2/3] nvmet-tcp: Don't free SQ on authentication success
Christoph Hellwig
hch at lst.de
Fri Oct 31 07:03:10 PDT 2025
On Thu, Oct 30, 2025 at 01:51:13PM +1000, alistair23 at gmail.com wrote:
> Curently after the host sends a REPLACETLSPSK we free the TLS keys as
> part of calling nvmet_auth_sq_free() on success. This means when the
> host sends a follow up REPLACETLSPSK we return CONCAT_MISMATCH as the
> check for !nvmet_queue_tls_keyid(req->sq) fails.
>
> This patch ensures we don't free the TLS key on success as we might need
> it again in the future.
I initially though we'd now keep it around for the lifetime of the
queue, but I think we'll still free it from nvmet_execute_auth_send,
right?
More information about the Linux-nvme
mailing list