This actually has block and nvme bits, so the subject line should say that. > + unsigned int attrs = 0; attrs is always zero here, no need to start passing it for the map_phys conversion alone. > + unsigned int attrs = 0; Same here. > + unsigned int attrs; And this is also entirely unused as far as I can tell.