Re: [PATCH V4 1/2] nvme-tcp: Prevent infinite loop if socket closes during CONNECTING state【请注意,邮件由sagigrim at gmail.com代发】
Maurizio Lombardi
mlombard at bsdbackstore.eu
Mon Oct 20 23:14:53 PDT 2025
On Tue Oct 21, 2025 at 8:05 AM CEST, Maurizio Lombardi wrote:
> On Tue Oct 21, 2025 at 5:37 AM CEST, zhang.guanghui at cestc.cn wrote:
>> This patch has not been merged yet,
>> So far, no other issues were found after merging this patch.
>
> Wait, do not merge it.
>
> nvme_tcp_error_recovery() should only be called when an -ENOPIPE error
> is detected. Other errors may be temporary, like -ENOPERM, and we
> shouldn't reset the connection in that case.
>
> Merging this patch as-is will make the blktests md/001 fail.
>
> Let me re-post a new version.
Also, as Sagi pointed out, during the initial connect there is no
expectation of error recovery, so there is more work to do.
Going to see if I can come up with something more robust.
Maurizio
More information about the Linux-nvme
mailing list