[PATCH V3 5/6] f2fs: ignore discard return value
Chao Yu
chao at kernel.org
Mon Nov 24 17:10:00 PST 2025
On 11/25/2025 7:48 AM, Chaitanya Kulkarni wrote:
> __blkdev_issue_discard() always returns 0, making the error assignment
> in __submit_discard_cmd() dead code.
>
> Initialize err to 0 and remove the error assignment from the
> __blkdev_issue_discard() call to err. Move fault injection code into
> already present if branch where err is set to -EIO.
>
> This preserves the fault injection behavior while removing dead error
> handling.
>
> Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn at wdc.com>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> Signed-off-by: Chaitanya Kulkarni <ckulkarnilinux at gmail.com>
Reviewed-by: Chao Yu <chao at kernel.org>
Thanks,
More information about the Linux-nvme
mailing list