Chaitanya, > __blkdev_issue_discard() always returns 0, making the error assignment > in __submit_discard_cmd() dead code. With Christoph's and Johannes' comments addressed. Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com> -- Martin K. Petersen