[PATCH 3/3] nvme: Allow reauth from sysfs
Christoph Hellwig
hch at lst.de
Wed Nov 12 00:32:03 PST 2025
On Wed, Nov 12, 2025 at 08:21:41AM +0100, Hannes Reinecke wrote:
>
> 'tls_configured_key' prints out the value of
> ctrl->opts->tls_key, ie the key passed in from the 'connect'
> string. Normally this value will be empty,
> as the 'connect' command will pick up the TLS key from
> the keyring automatically.
>
> 'tls_key' prints out the value of
> ctrl->tls_pskid, ie the value of the _negotiated_ key.
>
> So why is 'tls_configured_key' key the better option?
> Personally I think that 'tls_key' is more 'natural',
> as we want to replace the negotiated key, not the
> configured key ...
I've not even looked into what is better, but accepting anything
without validity checking tends to always bite us later.
More information about the Linux-nvme
mailing list