[PATCH v2 09/10] nvme-tcp: use crc32c() and skb_copy_and_crc32c_datagram_iter()

Hannes Reinecke hare at suse.de
Wed May 21 03:17:25 PDT 2025


On 5/19/25 19:50, Eric Biggers wrote:
> From: Eric Biggers <ebiggers at google.com>
> 
> Now that the crc32c() library function directly takes advantage of
> architecture-specific optimizations and there also now exists a function
> skb_copy_and_crc32c_datagram_iter(), it is unnecessary to go through the
> crypto_ahash API.  Just use those functions.  This is much simpler, and
> it also improves performance due to eliminating the crypto API overhead.
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
> Signed-off-by: Eric Biggers <ebiggers at google.com>
> ---
>   drivers/nvme/host/Kconfig |   4 +-
>   drivers/nvme/host/tcp.c   | 124 ++++++++++++--------------------------
>   2 files changed, 42 insertions(+), 86 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare at suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich



More information about the Linux-nvme mailing list