[PATCH 1/1] nvme: fix implicit bool to flags conversion
Caleb Sander Mateos
csander at purestorage.com
Tue May 20 08:42:36 PDT 2025
On Tue, May 20, 2025 at 8:28 AM Pavel Begunkov <asml.silence at gmail.com> wrote:
>
> nvme_map_user_request() takes flags as the last argument, but
> nvme_uring_cmd_io() shoves a bool "vec" into it. It behaves as
> expected because bool is converted to 0/1 and NVME_IOCTL_VEC is
> defined as 1, but it's better to pass flags explicitly.
>
> Fixes: 7b7fdb8e2dbc1 ("nvme: replace the "bool vec" arguments with flags in the ioctl path")
> Signed-off-by: Pavel Begunkov <asml.silence at gmail.com>
Keith had an earlier patch to fix this, but looks like the series
never got merged:
https://lore.kernel.org/linux-nvme/20250224182128.2042061-4-kbusch@meta.com/
This approach also looks fine to me, but not sure if it will
complicate some of the changes Keith wanted to make.
Reviewed-by: Caleb Sander Mateos <csander at purestorage.com>
More information about the Linux-nvme
mailing list