[PATCH 5/7] nvme-pci: use a better encoding for small prp pool allocations

Leon Romanovsky leon at kernel.org
Tue May 13 00:49:26 PDT 2025


On Tue, May 13, 2025 at 09:40:41AM +0200, Christoph Hellwig wrote:
> On Tue, May 13, 2025 at 10:39:50AM +0300, Leon Romanovsky wrote:
> > > +static inline struct dma_pool *nvme_dma_pool(struct nvme_queue *nvmeq,
> > > +		struct nvme_iod *iod)
> > > +{
> > 
> > You probably want __always_inline and not inline here.
> 
> I avoid that if I can.  People trying to use non-optimizing compiler
> flag deserve what they asked for :)

Right, but you are trying to sit on two seats here.

For users who uses normal compiler, this two line function will be
inlined anyway without need in extra "inline" keyword.
For users with "non-optimizing compiler", this "inline" keyword will do
nothing.

Thanks 



More information about the Linux-nvme mailing list