[PATCH 1/7] nvme-pci: don't try to use SGLs for metadata on the admin queue

Christoph Hellwig hch at lst.de
Tue May 13 00:39:08 PDT 2025


On Tue, May 13, 2025 at 10:28:42AM +0300, Leon Romanovsky wrote:
> > -	if (nvme_pci_metadata_use_sgls(dev, req))
> > +	struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
> > +
> > +	if ((iod->cmd.common.flags & NVME_CMD_SGL_METABUF) &&
> 
> Won't it be more future error proof to check for NVME_CMD_SGL_ALL?

No really, as this is used to decide to call into the routine that
sets NVME_CMD_SGL_METASEG.




More information about the Linux-nvme mailing list