[PATCH 3/4] nvmet: pci-epf: Cleanup nvmet_pci_epf_raise_irq()

Damien Le Moal dlemoal at kernel.org
Thu May 8 16:16:54 PDT 2025


On 5/8/25 10:07 PM, Niklas Cassel wrote:
> Nit: since we no longer perform the NVMET_PCI_EPF_Q_IRQ_ENABLED check in
> nvmet_pci_epf_should_raise_irq(), should we rename the function to something
> else? nvmet_pci_epf_irq_allowed() ? Any ideas ?

nvmet_pci_epf_should_raise_irq() is still in charge of handling IRQ coalescing,
returning true if we should raise an IRQ and false if the IRQs are still being
coalesced. So the name as is still seems fine to me.

> Reviewed-by: Niklas Cassel <cassel at kernel.org>

Thanks.


-- 
Damien Le Moal
Western Digital Research



More information about the Linux-nvme mailing list