[PATCH 01/12] nvme-auth: modify nvme_auth_transform_key() to return status

Hannes Reinecke hare at suse.de
Wed May 7 00:29:13 PDT 2025


On 5/7/25 09:24, Christoph Hellwig wrote:
> On Fri, Apr 25, 2025 at 11:49:16AM +0200, Hannes Reinecke wrote:
>> Modify nvme_auth_transform_key() to return a status and provide
>> the transformed data as argument on the command line as raw data.
> 
> Well, it's pretty obvious that you do this from the code changes.
> 
> But why do you change it?
> 
You are right, the description is incorrect.
Main point here is to return a raw byte string containing the
transformed key data (and not a key structure).
Doing so makes the following modifications easier to read.
One hopes.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich



More information about the Linux-nvme mailing list