[PATCH] nvme-pci: Make nvme_pci_npages_prp() __always_inline
Christoph Hellwig
hch at lst.de
Tue May 6 23:59:13 PDT 2025
On Tue, May 06, 2025 at 10:55:31PM -0700, Kees Cook wrote:
> On Wed, May 07, 2025 at 06:47:54AM +0200, Christoph Hellwig wrote:
> > On Tue, May 06, 2025 at 08:35:40PM -0700, Kees Cook wrote:
> > > The only reason nvme_pci_npages_prp() could be used as a compile-time
> > > known result in BUILD_BUG_ON() is because the compiler was always choosing
> > > to inline the function. Under special circumstances (sanitizer coverage
> > > functions disabled for __init functions on ARCH=um), the compiler decided
> > > to stop inlining it:
> >
> > Can we place just fix um to still force inlining inline functions instead
> > of needing these workarounds?
>
> Oh, I don't have the history here. Is there something about UM and
> forcing off inlining?
Maybe I'm misunderstandng your report, but what causes the failure
to inline?
More information about the Linux-nvme
mailing list