[PATCH 2/2] nvme: all namespaces in a subsystem must adhere to a common atomic write size

Christoph Hellwig hch at lst.de
Thu May 1 23:52:39 PDT 2025


On Wed, Apr 30, 2025 at 10:18:30AM -0700, Alan Adamson wrote:
> The first namespace that is configured in a subsystem will define the
> subsystem's atomic write size.  This will be based on either AWUPF or
> NAWUPF. Configuring subsequent namespaces in the subsystem requires its
> atomic write size as defined by its AWUPF or NAWUPF to match the
> subsystem's atomic write size. If a namespace doesn't adhere to the
> subsystem's atomic write size, its atomic queue limits will be based on an
> atomic write size of 512 bytes and an error message will be logged.

I don't think an error message is enough, we need to reject the probe
for this buggy configuration to prevent data integrity issues.

Otherwise the series looks good to me.




More information about the Linux-nvme mailing list