[PATCH 0/1] NVMe/TLS connection issues to SPDK

Daniel Wagner dwagner at suse.de
Thu Jul 24 08:37:02 PDT 2025


Hi Chris,

On Thu, Jul 24, 2025 at 08:07:03AM -0700, Chris Leech wrote:
> I believe Hannes has given a reviewed tag on the libvnme patch.  The
> discussion on the cover letter is about future work on the kernel
> side.

Ah, thanks. Trimming emails would help.

> If it would help I can capture that tag and then submit this as a
> github PR.

The PR has the advantage that a CI build gets triggered. Submissions on
the mailing list are usually in good shape. Submissions via GitHub vary
quite a bit. I’m fine either way. :)

> Actually, I think I might be missing an explicit NULL assignment on
> the declaration of *str to keep _cleanup_free_ safe?

For _cleanup_free_ to work, the variable needs to be initialized (either
NULL or a valid pointer) before the block scope is left. Otherwise the
free sees a random stack value.

Thanks,
Daniel



More information about the Linux-nvme mailing list