[PATCH 3/9] nvme-auth: switch to use 'struct key'

[Hannes Reinecke]

On 11/30/25 22:44, Sagi Grimberg wrote:
> 
> 
> On 27/11/2025 10:15, Hannes Reinecke wrote:
>> On 11/26/25 08:53, Sagi Grimberg wrote:
>>>
>>>
[ .. ]
>>>
>>> It is a bit confusing that you replace a generate_key with an 
>>> extract_key function.
>>> Can you explain a bit on this?
>>>
>>
>> It was probably a misnomer to start with.
>> 'nvme_auth_generate_key()' constructs a 'struct nvme_dhchap_key'
>> from the input parameters on the commandline.
>> (And so in a sense 'generates' it, without having anything to do
>> with the 'generated' key in the NVMe sense).
>> And internally 'nvme_auth_generate_key()' is a wrapper around 
>> 'nvme_auth_extract_key()' anyway.
> 
> This makes sense. Can you please put this in the patch description?

Sure. Will do for the next round.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich