[PATCH 2/2] nvme: extend show-topology command to add support for multipath

[Daniel Wagner]

Hi Nilay,

Sorry, I forgot about to reply.

On Tue, Aug 05, 2025 at 10:31:35AM +0530, Nilay Shroff wrote:
> > Example verbose output:
> > 
> > $ nvme show-topology --verbose -r multipath
> > 
> > nvme-subsys2 - NQN=nvmet_subsystem
> >                hostnqn=nqn.2014-08.org.nvmexpress:uuid:12b49f6e-0276-4746-b10c-56815b7e6dc2
> >                iopolicy=numa
> >                model=Linux
> >                serial=d5dc1170f62100d47204
> >                firmware=6.16.0-r
> >                type=nvm
> > 
> > <head-node> <namespace>   <path>    <ana-state>  <numa-list>  <queue-depth>   <ctrl>  <state>  <transport>    <address>                  
> >     |          |             |           |           |            |              |       |          |             |
> > nvme2n1        1          nvme2c2n1   optimized     1,2           0            nvme2   live        tcp        traddr=127.0.0.2,trsvcid=4460,src_addr=127.0.0.1 
> > nvme2n1        1          nvme2c3n1   optimized     3,4           0            nvme3   live        tcp        traddr=127.0.0.3,trsvcid=4460,src_addr=127.0.0.1
> > 
> > What do you think?

Personally, I did like the previous annotation layout, probably because
I am looking way to often the ftrace output. Though, I'd say it would be
better to stick with the existing table layout, instead adding something
completely new (nvme list, nvme list -v, etc).

Maybe introducing a bit of common code for printing these tables could
make it also a bit more streamlined, just as an idea.

Thanks,
Daniel