[PATCH 1/4] fc_els: use 'union fc_tlv_desc'

Justin Tee justintee8345 at gmail.com
Mon Apr 28 17:32:15 PDT 2025


Hi Hannes,

May we also update lpfc’s function header argument’s description name as well?

diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index cf1fbfb15c5d..9abab90edc61 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -9938,7 +9938,7 @@ lpfc_display_fpin_wwpn(struct lpfc_hba *phba,
__be64 *wwnlist, u32 cnt)
 /**
  * lpfc_els_rcv_fpin_li - Process an FPIN Link Integrity Event.
  * @phba: Pointer to phba object.
- * @tlv:  Pointer to the Link Integrity Notification Descriptor.
+ * @li:  Pointer to the Link Integrity Notification Descriptor.
  *
  * This function processes a Link Integrity FPIN event by logging a message.
  **/
@@ -9968,7 +9968,7 @@ lpfc_els_rcv_fpin_li(struct lpfc_hba *phba,
struct fc_fn_li_desc *li)
 /**
  * lpfc_els_rcv_fpin_del - Process an FPIN Delivery Event.
  * @phba: Pointer to hba object.
- * @tlv:  Pointer to the Delivery Notification Descriptor TLV
+ * @del:  Pointer to the Delivery Notification Descriptor TLV
  *
  * This function processes a Delivery FPIN event by logging a message.
  **/
@@ -10005,7 +10005,7 @@ lpfc_els_rcv_fpin_del(struct lpfc_hba *phba,
struct fc_fn_deli_desc *del)
 /**
  * lpfc_els_rcv_fpin_peer_cgn - Process a FPIN Peer Congestion Event.
  * @phba: Pointer to hba object.
- * @tlv:  Pointer to the Peer Congestion Notification Descriptor TLV
+ * @pc:  Pointer to the Peer Congestion Notification Descriptor TLV
  *
  * This function processes a Peer Congestion FPIN event by logging a message.
  **/
@@ -10039,7 +10039,7 @@ lpfc_els_rcv_fpin_peer_cgn(struct lpfc_hba
*phba, struct fc_fn_peer_congn_desc *
 /**
  * lpfc_els_rcv_fpin_cgn - Process an FPIN Congestion notification
  * @phba: Pointer to hba object.
- * @tlv:  Pointer to the Congestion Notification Descriptor TLV
+ * @cgn:  Pointer to the Congestion Notification Descriptor TLV
  *
  * This function processes an FPIN Congestion Notifiction.  The notification
  * could be an Alarm or Warning.  This routine feeds that data into driver's

Regards,
Justin



More information about the Linux-nvme mailing list