[RFC PATCHv2 1/3] nvme-multipath: introduce delayed removal of the multipath head node

Sagi Grimberg sagi at grimberg.me
Fri Apr 25 15:26:42 PDT 2025


>   
> @@ -3688,6 +3688,8 @@ static struct nvme_ns_head *nvme_alloc_ns_head(struct nvme_ctrl *ctrl,
>   	ratelimit_state_init(&head->rs_nuse, 5 * HZ, 1);
>   	ratelimit_set_flags(&head->rs_nuse, RATELIMIT_MSG_ON_RELEASE);
>   	kref_init(&head->ref);
> +	if (ctrl->opts)

While this check is correct, perhaps checking ctrl->ops->flags & 
NVME_F_FABRICS
would be clearer.




More information about the Linux-nvme mailing list