[PATCHv2 2/4] tree: add queue-depth attribute for nvme path object
Nilay Shroff
nilay at linux.ibm.com
Tue Apr 22 23:13:54 PDT 2025
On 4/22/25 10:53 PM, Daniel Wagner wrote:
> On Tue, Apr 22, 2025 at 08:02:49PM +0530, Nilay Shroff wrote:
>>> As discussed: saving the 'queue_depth' attribute is a bad idea, as it
>>> changes frequently.
>>> I'd rather read the attribute value from sysfs whenever
>>> 'nvme_path_get_queue_depth' is called, and use the tree structure only
>>> to hold the pathname.
>>>
>> Yes correct, but I thought we discussed about implementing non-cached
>> version of API in libnvme 2.x. So I implemented cached version of
>> queue_depth API. Daniel can you confirm?
>
> I was under the impression that we agreed on the default being
> non-cached. As it doesn't really make sense to have a cached anyway.
Okay, my bad.. probably some misunderstanding on my part.
I will fix this in the next version of this patch.
Thanks,
--Nilay
More information about the Linux-nvme
mailing list