[PATCH v2 2/2] nvme/pci: make PRP list DMA pools per-NUMA-node

[Keith Busch]

On Mon, Apr 21, 2025 at 10:17:25AM -0600, Caleb Sander Mateos wrote:
> +static void nvme_release_prp_pools(struct nvme_dev *dev)
> +{
> +	struct nvme_prp_dma_pools *pools_end = dev->prp_pools + nr_node_ids;
> +	struct nvme_prp_dma_pools *prp_pools;
> +
> +	for (prp_pools = dev->prp_pools; prp_pools < pools_end; prp_pools++) {
> +		if (!prp_pools->small)
> +			continue;
> +
> +		dma_pool_destroy(prp_pools->large);
> +		dma_pool_destroy(prp_pools->small);
> +	}
> +}

A minor difference in style, I think indexing looks cleaner than
incrementing pointers: 

static void nvme_release_prp_pools(struct nvme_dev *dev)
{
	int i;

	for (i = 0; i < nr_node_ids; i++) {
		dma_pool_destroy(dev->prp_pools[i].small);
		dma_pool_destroy(dev->prp_pools[i].large);
	}
}

Note, dma_pool_destroy() already checks for NULL, so no need to check
before calling it.