nvme-cli connect regression

[Keith Busch]

On Wed, Apr 16, 2025 at 12:14:28AM +0300, Sagi Grimberg wrote:
> 
> 
> On 15/04/2025 12:01, Daniel Wagner wrote:
> > On Mon, Apr 14, 2025 at 01:29:42AM +0300, Sagi Grimberg wrote:
> > > Was this resolved?
> > I've added a retry loop in libnvme when the write to /dev/nvme-fabrics
> > returns EINTR. It takes a few days until the newly version hits the test
> > frameworks and we know for sure that is handled.
> > 
> > > Couldn't follow where the issue was - kernel/userspace?
> >    [ 10.397892] nvme_tcp: queue 0: failed to receive icresp, error -4
> > 
> > Stable kernels started to return EINTR and one change which touches
> > this area is:
> > 
> >    578539e09690 ("nvme-tcp: fix connect failure on receiving partial ICResp PDU")
> > 
> > Unfortunately, it's not easy for Luca to build a test kernel. If we
> > provide one for his distro, he would be willing to tests.
> 
> Its not great that we now get sporadic EINTR errors. I am wandering what is
> triggering this?

The only EINTR return value I can find in this path is from
sock_intr_errno(). So something is signalling the nvme process, which
could be anything.