[PATCHv2] nvme-multipath: sysfs links may not be created for devices

Nilay Shroff nilay at linux.ibm.com
Mon Apr 14 23:49:50 PDT 2025



On 4/15/25 12:17 PM, Hannes Reinecke wrote:
> When rapidly rescanning for new namespaces nvme_mpath_add_sysfs_link() may be
> called for a block device not added to sysfs. But NVME_NS_SYSFS_ATTR_LINK
> had already been set, so when checking this device a second time we will fail
> to create the link.
> 
> Fix this by exchanging the order of the block device check and the
> NVME_NS_SYSFS_ATTR_LINK bit check.
> 
> Fixes: 4dbd2b2ebe4c ("nvme-multipath: Add visibility for round-robin io-policy")
> 
> Signed-off-by: Hannes Reinecke <hare at kernel.org>
> Cc: Nilay Shroff <nilay at linux.ibm.com>

Looks good to me:
Reviewed-by: Nilay Shroff <nilay at linux.ibm.com>



More information about the Linux-nvme mailing list