[PATCH 0/2] nvme: handle partially unique NID value

[Hannes Reinecke]

On 4/14/25 13:19, Christoph Hellwig wrote:
> On Mon, Apr 14, 2025 at 11:09:57AM +0200, hare at kernel.org wrote:
>> From: Hannes Reinecke <hare at kernel.org>
>>
>> Hi all,
>>
>> we have encountered a customer issue where the NID values for additional
>> namespaces on the same device are not unique in all cases; the NGUID is,
>> but the EUI64 is not. Problem is that prior to commit e2724cb9f0c4 there
>> devices worked without a problem, but after that all NIDs are blanked out.
>> This results in udev not creating persistent device links anymore and the
>> system failing to boot.
> 
> These devices are so broken that we absolutely should not support them
> You've also received that feedback both in person from me, from Daniel
> and from the nvme technical working group.  I'm not sure why you insist
> resending it instead of telling the OEM that specifically requested this
> spec violating behavior from their SSD vendor to stop doing those
> broken thing in the many months you have known of this gravely incorrect
> indefensible behavior.
> 
Thank you for your kind words.

We have discussed this at LSF, and the involved parties (ie
Samsung as the vendor, HPe as the IHV, and us as the OS provider)
are happy with this approach.
And we have paying customers for which the cited patch caused a 
regression, so ignoring it is not an option for us.
I hoped this patchset would be acceptable for upstream; as it is not
we will have to include this patchset as a SUSE-specific modification.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich